Skip to content

Set dont_forward on private channel updates and add tests#4340

Merged
TheBlueMatt merged 4 commits intolightningdevkit:mainfrom
Thrishalmadasu:issue-1672-dont-forward-bit
Feb 2, 2026
Merged

Set dont_forward on private channel updates and add tests#4340
TheBlueMatt merged 4 commits intolightningdevkit:mainfrom
Thrishalmadasu:issue-1672-dont-forward-bit

Conversation

@Thrishalmadasu
Copy link
Contributor

@Thrishalmadasu Thrishalmadasu commented Jan 23, 2026 •
edited
Loading

Fixes #1672.

Changes:

  • Set the dont_forward bit (message_flags bit 1) on channel_update messages for private channels
  • Filter out inbound channel_update gossip messages that have dont_forward set in P2PGossipSync
  • Log a debug message when receiving a channel_update with dont_forward set for an unknown channel, suggesting the user check the tx_index passed to chain::Confirm::transactions_confirmed

Details

Outbound flag setting:

  • In ChannelManager::get_channel_update_for_unicast, we now set:
    • message_flags = 1 | (1 << 1) for private channels (must_be_one + dont_forward)
    • message_flags = 1 for public channels (must_be_one only)

Inbound filtering:

  • In P2PGossipSync::handle_channel_update, channel updates with the dont_forward bit set are rejected with ErrorAction::IgnoreAndLog(Level::Debug) to prevent them from polluting the network graph

Diagnostic logging:

  • In internal_channel_update, if we receive a channel_update for an unknown SCID with dont_forward set, we log a debug message suggesting the user verify the tx_index passed to chain::Confirm::transactions_confirmed

Tests

  • handling_channel_update_with_dont_forward_flag - verifies gossip layer rejects updates with dont_forward bit
  • test_channel_update_dont_forward_flag - verifies private channels set the flag, public channels don't
  • test_unknown_channel_update_with_dont_forward_logs_debug - verifies debug logging for unknown channel updates

Based on lightning/bolts#999: BOLT 7 dont_forward flag for SCID aliases.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 23, 2026 •
edited
Loading

👋 I see @wpaulino was un-assigned.
If you'd like another reviewer assignment, please click here.

@codecov
Copy link

codecov bot commented Jan 23, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.00%. Comparing base (8cdc86a) to head (5e32d69).
⚠️ Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/routing/gossip.rs 97.61% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4340      +/-   ##
==========================================
- Coverage   86.53%   86.00%   -0.54%     
==========================================
  Files         158      156       -2     
  Lines      103190   102652     -538     
  Branches   103190   102652     -538     
==========================================
- Hits        89300    88285    -1015     
- Misses      11469    11857     +388     
- Partials     2421     2510      +89
Flag Coverage Δ
fuzzing ?
tests 86.00% <97.77%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Thrishalmadasu Thrishalmadasu marked this pull request as ready for review January 23, 2026 11:45
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 26, 2026

🔔 1st Reminder

Hey @wpaulino! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@TheBlueMatt TheBlueMatt removed the request for review from wpaulino January 26, 2026 14:41
TheBlueMatt
TheBlueMatt reviewed Jan 26, 2026
View reviewed changes
@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Jan 30, 2026

We should also ignore updates we receive with the bit set in our network graph/p2pgossipmessagehandler.

TheBlueMatt
TheBlueMatt approved these changes Feb 2, 2026
View reviewed changes
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheBlueMatt TheBlueMatt merged commit fdacec8 into lightningdevkit:main Feb 2, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set the new dont_forward bit in channel_update messages

3 participants

@Thrishalmadasu @ldk-reviews-bot @TheBlueMatt